This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Add ID to views #50788
Merged
[Windows] Add ID to views #50788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return std::chrono::nanoseconds(interval); | ||
| } | ||
|
|
||
| FlutterWindowsView* FlutterWindowsEngine::view(FlutterViewId view_id) const { |
Contributor
There was a problem hiding this comment.
Should we add a unit test for this now to test the implicit view ID and make sure we update everything in sync when removing that assumption?
Member
Author
There was a problem hiding this comment.
What do you have in mind that we need to be kept in sync? Would the test verify that the engine crashes if a non-zero ID is given?
Personally I think it'd be okay without this test. If I'm understanding you correctly, all our existing tests effectively verify this by not crashing. Please let me know if you feel strongly about this though!
loic-sharma
force-pushed
the
windows_view_id
branch
from
e2b8a1c to
ec6b484
Compare
yaakovschectman
approved these changes
Feb 20, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2024
…143791) flutter/engine@1ae2c10...cb12a8c 2024-02-20 [email protected] [Windows] Add ID to views (flutter/engine#50788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ID to a view:
FlutterWindowsViewnow has a IDFlutterWindowsEngine::view(...)accessor now requires a view ID parameterThis is a refactoring with no semantic changes.
Part of flutter/flutter#143765
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.