This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Web] Update modifier state when Meta key is seen as Process key #50779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
changed the title
dkwingsmt
approved these changes
Feb 20, 2024
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM. Yeah I think for such a special corner case, this kind of logic is fine. We can find a more generalized solution if we run into more similar issues.
bleroux
added
the
autosubmit
bleroux
deleted the
web_update_key_event_when_MetaLeft_is_seen_as_Process
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 21, 2024
…143820) flutter/engine@efc6994...9100d32 2024-02-21 [email protected] [Web] Update modifier state when Meta key is seen as Process key (flutter/engine#50779) 2024-02-21 [email protected] Add pub.dev to the hosted package URIs checked by the pub_get_offline script (flutter/engine#50811) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Web, browsers can emit key events with a logical key sets to
Processwhen the physical key is MetaLeft. Because the modifier state is 0 despite Meta key being pressed this will trigger an assert.This PR adds some logic for this specific case. Maybe a more slightly broader solution will be needed (using the same logic for all modifiers ?). I focused on MetaLeft because it was directly reported on flutter/flutter#141186.
Related Issue
Fixes flutter/flutter#141186.
Tests
Adds 1 test.