[Impeller] force bootstrap render pass. #50749
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
| // Creating a render pass is observed to take an additional 6ms on a Pixel 7 | ||
| // device as the driver will lazily bootstrap and compile shaders to do so. | ||
| // The render pass does not need to be begun or executed. | ||
| void ContextVK::InitializeCommonlyUsedShadersIfNeeded() const { |
There was a problem hiding this comment.
Its really unclear how this is about shaders. Perhaps InitializeCommonlyUsedRenderPassesIfNeeded?
There was a problem hiding this comment.
The doc comment describes why this is about shaders
There was a problem hiding this comment.
I'm landing this but we can have another follow up discussion
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
A minor nit. LGTM otherwise.
jonahwilliams
added
the
autosubmit
…143862) flutter/engine@4128895...52ffcaa 2024-02-21 [email protected] [Impeller] force bootstrap render pass. (flutter/engine#50749) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Part of flutter/flutter#138236
Creating the first VkRenderPass takes 6ms on a Pixel 7.
In the previous PR I attempted to use the Impeller HAL API, but this caused more problems than it solved - breaking mocks and also leading to odd behavior I think may be due to threading issues when submitting the bootstrap cmd buffer.
It seems like all we need to do to trigger the shader compilation is create the render pass, so add a ContextVK override that creates and throws it away, without beginning the render pass, creating a cmd buffer, or doing any extra work.