[Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. #50742
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
force-pushed
the
bdero/more-depth
branch
from
7da322d to
e7e0605
Compare
|
This is now working as per the goldens. We don't generally test internal shader inputs directly. Should this be test exempt? |
|
Yes, malioc + goldens are tests |
…nder directly to an EntityPass. (flutter/engine#50742)
…143824) flutter/engine@9100d32...ed49634 2024-02-21 [email protected] [Impeller] Apply Entity depth in filter shaders that may render directly to an EntityPass. (flutter/engine#50742) 2024-02-21 [email protected] Roll Fuchsia Linux SDK from gKg6HlBeR52y-cMhu... to dLhvv964txwnSlvNw... (flutter/engine#50813) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gKg6HlBeR52y to dLhvv964txwn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
No description provided.