This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script #50735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…handle FTL infrastructure errors in the script This test had been temporarily moved to an API 33 device as a workaround for an FTL infrastructure issue (see flutter#50721) This PR resumes use of a Pixel 8/API 34 device for the FTL tests. It also retries the test if FTL returns an error code that is known to represent an FTL infrastructure error. If the retries fail, then the test script will not block the engine tree if all failures were caused by infrastructure. This is similar to what the CI recipes are doing in https://flutter.googlesource.com/recipes/+/a181878fde742dacd94afca04c5a4db1b3c30b91
jason-simmons
force-pushed
the
ftl_handle_infra_errors
branch
from
1065ff8 to
a451910
Compare
jason-simmons
changed the title
matanlurey
approved these changes
Feb 16, 2024
Contributor
|
Thank you lgtm |
reidbaker
approved these changes
Feb 16, 2024
|
|
||
| return_code = process.wait() | ||
| if return_code in FTL_INFRA_FAILURE_CODES: | ||
| print('Firebase test %s failed with infrastructure error code: %s' % (apk, return_code)) |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2024
…cript and handle FTL infrastructure errors in the script (flutter/engine#50735)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2024
…143624) flutter/engine@2ed159a...e51d4f1 2024-02-17 [email protected] Connect signals in swapped form. (flutter/engine#50705) 2024-02-17 [email protected] Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script (flutter/engine#50735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test had been temporarily moved to an API 33 device as a workaround for an FTL infrastructure issue (see #50721)
This PR resumes use of a Pixel 8/API 34 device for the FTL tests. It also retries the test if FTL returns an error code that is known to represent an FTL infrastructure error. If the retries fail, then the test script will not block the engine tree if all failures were caused by infrastructure.
This is similar to what the CI recipes are doing in https://flutter.googlesource.com/recipes/+/a181878fde742dacd94afca04c5a4db1b3c30b91