This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove unused allowInterop usage in flutter web code
#50718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLs that migrated to static interop forgot to update the corresponding comments regarding the need to use `allowInterop`. The re-exported `allowInterop` function happened in an internal library (not exposed via `dart:ui*`) and was unused.
srujzs
approved these changes
Feb 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
…143609) flutter/engine@13dc857...2eed3fb 2024-02-16 [email protected] Temporarily disable goldens for Safari. (flutter/engine#50724) 2024-02-16 [email protected] [web] Remove unused `allowInterop` usage in flutter web code (flutter/engine#50718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLs that migrated to static interop forgot to update the corresponding comments regarding the need to use
allowInterop.The re-exported
allowInteropfunction happened in an internal library (not exposed viadart:ui*) and was unused.Issue dart-lang/sdk#54908