This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Starts a command line tool for assisting engine dev workflows #50642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
engine-tool-start
branch
from
6794bfc to
765ca71
Compare
matanlurey
approved these changes
Feb 14, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Seems reasonable to me, thanks!
johnmccutchan
approved these changes
Feb 14, 2024
zanderso
force-pushed
the
engine-tool-start
branch
from
765ca71 to
e0cf224
Compare
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
reviewed
Feb 14, 2024
loic-sharma
approved these changes
Feb 14, 2024
zanderso
force-pushed
the
engine-tool-start
branch
from
e0cf224 to
c3206f5
Compare
Merged
zanderso
added a commit
that referenced
this pull request
Feb 14, 2024
Follow-up on #50642, which added tests, but didn't run them. This PR runs them.
sealesj
pushed a commit
to sealesj/engine
that referenced
this pull request
Feb 15, 2024
Follow-up on flutter#50642, which added tests, but didn't run them. This PR runs them.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
Run engine_tool tests (flutter/engine#50662) Refactor, update, and move around `testing/scenario_app/README.md` (flutter/engine#50659) Starts a command line tool for assisting engine dev workflows (flutter/engine#50642) macOS: add stubs for PlatformView gesture handling (flutter/engine#50630) [Impeller] Conditionally use A8 or R8 format glyph atlas based on capabilities. (flutter/engine#50534) Roll Dart SDK from e7cfba13d375 to 322e34dc53f6 (1 revision) (flutter/engine#50651) Roll Skia from 4235c0421a48 to eae42ea9f7bc (2 revisions) (flutter/engine#50650) Roll Skia from ea2fd25220cb to 4235c0421a48 (1 revision) (flutter/engine#50648) Roll Dart SDK from 9982d96cebb0 to e7cfba13d375 (1 revision) (flutter/engine#50646) Roll Skia from 1e6e2114f15e to ea2fd25220cb (1 revision) (flutter/engine#50643) Roll Dart SDK from 032323fa534b to 9982d96cebb0 (1 revision) (flutter/engine#50644) Roll Skia from 2aec75cda46e to 1e6e2114f15e (2 revisions) (flutter/engine#50641) Roll Skia from b8acfa559db0 to 2aec75cda46e (1 revision) (flutter/engine#50639) Roll Fuchsia Linux SDK from l6mWjvlO1xJg5ZFKK... to mZP8LxbhYHstUxmxd... (flutter/engine#50638) Roll Skia from 79ec267090bd to b8acfa559db0 (1 revision) (flutter/engine#50636) Roll Skia from d650dcaf4b49 to 79ec267090bd (1 revision) (flutter/engine#50634)
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just trying to get some structure in place. I suspect that the implementation of the
querycommand in this PR will get entirely replaced through improvements.