This repository was archived by the owner on Feb 25, 2025. It is now read-only.
In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist #50629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipped does not exist lib.unstripped will not be created in a "gn --no-stripped" build See flutter#50443
gmackall
approved these changes
Feb 14, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM, though I'm pretty unfamiliar with this test in general!
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2024
… lib.unstripped does not exist (flutter/engine#50629)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2024
…143427) flutter/engine@0849250...3af336b 2024-02-14 [email protected] In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist (flutter/engine#50629) 2024-02-14 [email protected] Roll Dart SDK from a8303c0bf1b4 to 032323fa534b (1 revision) (flutter/engine#50631) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.unstripped will not be created in a "gn --no-stripped" build
See #50443