This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use a GN variable (dart_src) to reference the location of the Dart checkout. #50624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
platform-android
platform-web
chinmaygarde
force-pushed
the
dart_src
branch
from
6f56a81 to
b55e6c7
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Member
Author
|
There are no golden image changes. Its the bot being confused again. |
jason-simmons
approved these changes
Feb 15, 2024
chinmaygarde
added
the
autosubmit
whesse
reviewed
Feb 15, 2024
Contributor
whesse
left a comment
whesse
left a comment
There was a problem hiding this comment.
flutter_frontend_server/BUILD.gn needs to import flutter/build/dart/dart.gni, since it uses the $dart_src GN variable.
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
…#50685) Support for the dart_src GN variable was missing the import of the variable definition in the flutter_frontend_server BUILD.gn file. Follow up to #50624 Part of issue flutter/flutter#143335
sealesj
pushed a commit
to sealesj/engine
that referenced
this pull request
Feb 15, 2024
sealesj
pushed a commit
to sealesj/engine
that referenced
this pull request
Feb 15, 2024
…flutter#50685) Support for the dart_src GN variable was missing the import of the variable definition in the flutter_frontend_server BUILD.gn file. Follow up to flutter#50624 Part of issue flutter/flutter#143335
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 2024-02-15 [email protected] Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679) 2024-02-15 [email protected] Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678) 2024-02-15 [email protected] Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 2024-02-15 [email protected] Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 2024-02-15 [email protected] Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 2024-02-15 [email protected] Disable Android API v28 tests on CI. (flutter/engine#50672) 2024-02-15 [email protected] Use modern concurrency constructs. (flutter/engine#50671) 2024-02-15 [email protected] Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 2024-02-15 [email protected] Move boringssl to flutter/third_party. (flutter/engine#50601)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 2024-02-15 [email protected] Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679) 2024-02-15 [email protected] Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678) 2024-02-15 [email protected] Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 2024-02-15 [email protected] Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 2024-02-15 [email protected] Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 2024-02-15 [email protected] Disable Android API v28 tests on CI. (flutter/engine#50672) 2024-02-15 [email protected] Use modern concurrency constructs. (flutter/engine#50671) 2024-02-15 [email protected] Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 2024-02-15 [email protected] Move boringssl to flutter/third_party. (flutter/engine#50601)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#143335