[Impeller] replaces golden file count with a golden diff file #50621
Conversation
| print_divider('<') | ||
| print(f'Unexpected diff in {golden_path}, use `git apply` with the following patch.') | ||
| print('') | ||
| print(redirect_patch(diff_result.stdout.decode())) |
There was a problem hiding this comment.
Could the diff also be written to a file? That way we might also be able to teach CI to harvest the file, which could provide a better workflow than copy-pasting from the CI logs.
There was a problem hiding this comment.
I like the idea. I don't think there is prior art for that though. Copying and pasting the patch is how the license checker and the formatter work. You are thinking it could print out an url to a patch file? So you could do something like git apply | curl <url>?
There was a problem hiding this comment.
I mean git apply | curl <url> has the same workflow as copy and pasting the patch. It's just a smaller copy and paste =)
There was a problem hiding this comment.
If this script just writes the file, then later we can teach CI to harvest the file, upload it to storage, and include a link to it on the LUCI status page.
There was a problem hiding this comment.
I filed an proposal for that: flutter/flutter#143409
I'm not going to do it as part of this PR and we can prioritize it against the other stuff we need. This PR fixes a problem that needs to be addressed asap.
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50621, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gaaclarke
added
the
autosubmit
…143425) flutter/engine@215d55f...0849250 2024-02-14 [email protected] [Impeller] replaces golden file count with a golden diff file (flutter/engine#50621) 2024-02-14 [email protected] [Impeller] Migrate all ColorSourceContents to use a shared rendering routine. (flutter/engine#50261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
fixes flutter/flutter#143353
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.