This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] fix cmd buffer recycling bug in test. #50615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Feb 13, 2024
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Destructors are hard.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2024
…143411) flutter/engine@9b18387...abb51c4 2024-02-13 [email protected] [Windows] Refactor window destroyed app lifecycle event (flutter/engine#50565) 2024-02-13 [email protected] [Impeller] fix cmd buffer recycling bug in test. (flutter/engine#50615) 2024-02-13 [email protected] Roll Dart SDK from 04caefbfa60f to a8303c0bf1b4 (1 revision) (flutter/engine#50614) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative fix for a flake seen by @matanlurey . In the past we've seen race conditions when a single DeathRattle is used, because it actually gets destructed before the cmd pool state. By adding two and waiting we guaranteee that everything has completed in the resource manager.