This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Web] Ignore invalid keyboard events related to autofill #50590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
web_ignore_invalid_keyboard_event_related_to_autofill
branch
from
d1bd462 to
5b3a0b6
Compare
dkwingsmt
approved these changes
Feb 16, 2024
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
bleroux
deleted the
web_ignore_invalid_keyboard_event_related_to_autofill
branch
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
…143593) flutter/engine@dd530f1...5fd5ccf 2024-02-16 [email protected] Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721) 2024-02-16 [email protected] [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590) 2024-02-16 [email protected] Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Will this make it into a hotfix / dot release or would it wait for next stable? |
Contributor
|
I think it's unlikely to make into a hotfix. If you want to propose it as a hot fix, maybe you can discuss it in the discord server. |
|
This fix will help get Flutter into a production environments for web applications. Thank you. |
|
In what version this fix be included? |
Looks like 3.22.0 - it's listed in the Flutter 3.22.0 release notes |
|
This issue still persist in 3.22.2 version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an 'Unexpected null value' error related to autoFill.
When using Autofill feature, Chrome emits keyboard events whose
event.codeandevent.keyare null.Related Issue
Fixes flutter/flutter#114620.
Tests
Adds 1 test.