[Impeller] Remove the Vulkan queue submit thread and always present Vulkan images on the raster thread #50484
Conversation
…ulkan images on the raster thread The queue submit thread could sometimes call vkQueuePresentKHR while the raster thread is calling vkAcquireNextImageKHR. The simultaneous use of the swapchain on multiple threads violates Vulkan threading rules.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Testing: this is not a visible behavior change. The thread usage will be validated by the updated Vulkan validation layers that will be rolled as part of the next vulkan-deps roll (see flutter/flutter#141277) |
|
Ah, but you have now updated a test, making this change tested. Still LGTM |
jason-simmons
added
the
autosubmit
… present Vulkan images on the raster thread (flutter/engine#50484)
…143220) flutter/engine@1508b11...dcac986 2024-02-09 [email protected] [Impeller] Remove the Vulkan queue submit thread and always present Vulkan images on the raster thread (flutter/engine#50484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this change is necessary, but for the record, SkiaPerf recorded regressions in a few metrics and benchmarks on this change: https://flutter-flutter-perf.skia.org/e/?begin=1707444667&end=1707511041&keys=Xb99a247f2d22b4794028a722faed541f&num_commits=50&request_type=1&xbaroffset=39272 |
3 participants
The queue submit thread could sometimes call vkQueuePresentKHR while the raster thread is calling vkAcquireNextImageKHR. The simultaneous use of the swapchain on multiple threads violates Vulkan threading rules.