[Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn #50477
Conversation
…s/gn One has to manually `gn args` to add this flag (usually on macOS) now.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
autosubmit
…143258) flutter/engine@f969c52...41daa5b 2024-02-09 [email protected] [Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn (flutter/engine#50477) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@chinmaygarde why did we add this? This seems like a regression. Previously someone could test vulkan on mac os with Now they need Why would someone want to enable vulkan but not have playgrounds? We already have a runtime flag for enabling and disabling playgrounds. |
|
+1 ^ |
On macOS that would still not be enough for playgrounds. Thats because this GN flag was unset on macOS by default and there was no I originally thought this whole flag was unnecessary and tried to remove it but ran into validation errors. @gaaclarke apparently has fixed all of them however so this flag and the ways to enable it may be unnecessary. I'll submit a canary. But, I still don't think this is a regression. Previously, you had to |
|
Maybe I'm misremembering or maybe it was a broken flag. The opengles backend works like that where |
|
Yeah, OpenGL will work fine. Its the Vulkan stuff thats weird because of this extra condition. |
|
I tried removing the flags altogether in #50561 but there are still some remaining validation errors. |
4 participants
One has to manually
gn argsto add this flag (usually on macOS) now.