Sever the //flutter/vulkan dependency in Flutter in the Android embedder. #50472
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
No functional change. Just sets up the Impeller proc. table directly. |
|
test-exempt: No semantic change. |
chinmaygarde
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Unsure how to proceed here. The bot says there are golden changes which I wasn't expecting. But attempting to triage them reveals 0 diffs. Engine Chat pointed me to flutter/flutter#142244 which looks somewhat related. But that is dealing with PRs with force-pushes. Mine is a single commit with no updates. |
…der. The previous code was setting up a proc table, then getting the address of the proc that was used to the setup that table, then setting up another proc table. Directly setup the final proc table and don't depend on //impeller/vulkan. Part of flutter/flutter#143127 Similar to flutter#50454
chinmaygarde
force-pushed
the
no_flutter_vulkan_android
branch
from
74bda3b to
e881e53
Compare
|
Performing a rebase to ToT to see if that fixes the issue. |
…143199) flutter/engine@7b579dc...f9a169e 2024-02-09 [email protected] Sever the //flutter/vulkan dependency in Flutter in the Android embedder. (flutter/engine#50472) 2024-02-08 [email protected] Roll Skia from 59943f4e92b9 to 672bb50b6d8f (3 revisions) (flutter/engine#50476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
The previous code was setting up a proc table, then getting the address of the proc that was used to the setup that table, then setting up another proc table. Directly setup the final proc table and don't depend on //impeller/vulkan.
Part of flutter/flutter#143127
Similar to #50454