Updated CONTRIBUTING.md to have a testing section #50469
Conversation
| $ ./run_tests.py --variant=host_debug_unopt_arm64 --type=engine` | ||
| ``` | ||
|
|
||
| ### Directory |
There was a problem hiding this comment.
This seems valuable. I'm not 100% sold this is the right place. Maybe into the wiki? I ran out of gas updating it. I want to make sure it's something we want.
There was a problem hiding this comment.
I think this is a better place than the wiki since it will be versioned with changes in the engine. But either way is fine TBH. The wiki has a lower barrier to editing.
There was a problem hiding this comment.
Random thought for later: Maybe we could we just put these descriptions directly in run_tests.py and spit them out with a --list argument?
There was a problem hiding this comment.
The code could even be refactored to be data driven so we had the list in code.
There was a problem hiding this comment.
You don't even need the list in code. Let GN tell you what the test executables are. For instance gn desc out/host_debug_unopt_arm64/ :default deps --all --type=executable --testonly=true --as=output will tell their names.
Add --format=json to make it machine readable.
We could also create GN templates to add more metadata about the test that gn desc can dump out. IIRC, that is how the new build rules work as well.
|
|
||
| ## Fuchsia Contributions from Googlers | ||
|
|
||
| Googlers contributing to Fuchsia should follow the additional steps at: |
There was a problem hiding this comment.
For go links you can markdown linkify it by prepending http:// in the link decoration. That way folks don't have to copy it into their address bar.
There was a problem hiding this comment.
Good idea. I'm going to avoid touching it here though since it isn't part of the diff.
…143189) flutter/engine@6f5b6a3...9b37c68 2024-02-08 [email protected] Updated CONTRIBUTING.md to have a testing section (flutter/engine#50469) 2024-02-08 [email protected] Fix Core Foundation object leaks. (flutter/engine#50460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
fixes flutter/flutter#143087
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.