Fix Core Foundation object leaks. #50460
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
0xZOne
force-pushed
the
task/fix_leak
branch
2 times, most recently
from
4698f59 to
6892224
Compare
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
0xZOne
force-pushed
the
task/fix_leak
branch
3 times, most recently
from
9e224c1 to
be21c58
Compare
0xZOne
force-pushed
the
task/fix_leak
branch
2 times, most recently
from
7545ab1 to
b35a710
Compare
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Sound changes and lgtm but after using the utils already in fml. Thanks.
|
PTAL |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Unrelated, just as exciting: Today is the last day before the Chinese New Year, and I wish everyone a Happy New Year of the Dragon, Xin Nian Kuai Le! :)
Happy New Year. Hope its happy and prosperous for you and yours! 🤗
jason-simmons
added
the
autosubmit
…143189) flutter/engine@6f5b6a3...9b37c68 2024-02-08 [email protected] Updated CONTRIBUTING.md to have a testing section (flutter/engine#50469) 2024-02-08 [email protected] Fix Core Foundation object leaks. (flutter/engine#50460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This fixes Core Foundation object leaks.
Unrelated, just as exciting: Today is the last day before the Chinese New Year, and I wish everyone a Happy New Year of the Dragon, Xin Nian Kuai Le! :)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.