This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] move path out of PathBuilder in TakePath. #50444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
flar
approved these changes
Feb 7, 2024
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
LGTM, just a couple of questions/nits.
| }; | ||
|
|
||
| auto path1 = builder.TakePath(); | ||
| auto path1 = builder.CopyPath(); |
Contributor
There was a problem hiding this comment.
Should probably change the unit test name from "Taken" to "Copied".
impeller/geometry/path.cc
Outdated
| } | ||
|
|
||
| Path::Data Path::Data::Clone() const { | ||
| return Path::Data(*this); |
Contributor
There was a problem hiding this comment.
Is this method really needed compared to a public copy constructor?
Contributor
Author
There was a problem hiding this comment.
Not really, removed
matanlurey
approved these changes
Feb 7, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2024
…143131) flutter/engine@322a461...4ea7bd0 2024-02-07 [email protected] Roll Skia from 8332438cbeb9 to 91a9154d0dfa (2 revisions) (flutter/engine#50452) 2024-02-07 [email protected] [Impeller] move path out of PathBuilder in TakePath. (flutter/engine#50444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should move this path so we don't end up allocating/deallocating twice.
Fixes flutter/flutter#142873