Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke merged commit db0fb5f into flutter:main Feb 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 7, 2024
…143112)

flutter/engine@19ae46a...e4a5acc

2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision)" (flutter/engine#50450)
2024-02-07 [email protected] Roll Skia from a2fe78a31a14 to eacaa2d3600c (3 revisions) (flutter/engine#50445)
2024-02-07 [email protected] [Impeller] Initialize the stencil reference value. (flutter/engine#50373)
2024-02-07 [email protected] Roll Skia from 9b103a4148e2 to a2fe78a31a14 (2 revisions) (flutter/engine#50441)
2024-02-07 [email protected] Fixed CONTRIBUTING.md markdown lints (flutter/engine#50439)
2024-02-07 [email protected] Roll Skia from 7777976cd518 to 9b103a4148e2 (1 revision) (flutter/engine#50438)
2024-02-07 [email protected] Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision) (flutter/engine#50437)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants