This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ios] Fix memory leak in ChildClippingView #50389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xZOne
force-pushed
the
task/oc_mem
branch
3 times, most recently
from
947e412 to
76217ea
Compare
0xZOne
force-pushed
the
task/oc_mem
branch
2 times, most recently
from
5fc1bb5 to
17b19d5
Compare
0xZOne
changed the title
0xZOne
force-pushed
the
task/oc_mem
branch
3 times, most recently
from
5500abe to
fd3f7cd
Compare
jmagman
requested review from
hellohuanlin and
jmagman
and removed request for
cyanglaz
Contributor
|
@jmagman it's worth checking if this helps improving the platform view performance issue we are having. |
hellohuanlin
reviewed
Feb 7, 2024
Contributor
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
LGTM. Could you hold off landing it for now? we are having some perf issues with the platform view, and it may worth checking if this helps.
| } | ||
|
|
||
| - (void)testReleasesBackdropFilterSubviewsOnChildClippingViewDealloc { | ||
| __weak NSMutableArray<UIVisualEffectView*>* weakBackdropFilterSubviews = nil; |
Member
There was a problem hiding this comment.
Hm, why would this Objective-C local be snake case?
Contributor
There was a problem hiding this comment.
oh because i saw clipping_view below is snake case. maybe that should be camel case?
Member
There was a problem hiding this comment.
Yeah that one should have been camel case.
jmagman
approved these changes
Feb 8, 2024
| } | ||
|
|
||
| - (void)testReleasesBackdropFilterSubviewsOnChildClippingViewDealloc { | ||
| __weak NSMutableArray<UIVisualEffectView*>* weakBackdropFilterSubviews = nil; |
Member
There was a problem hiding this comment.
Hm, why would this Objective-C local be snake case?
Member
We aren't (currently) investigating memory leaks, I don't think we need to hold off on this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2024
…143138) flutter/engine@45137ea...104804a 2024-02-08 [email protected] [ios] Fix memory leak in ChildClippingView (flutter/engine#50389) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the memory leak in
ChildClippingView.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.