[Impeller] Initialize the stencil reference value. #50373
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Does the test that was failing run on CI in a way that will catch this? If not, is there a way to make it do so?
|
I think we'll get a lot of value for free by just running the existing playgrounds harness with This should have been easily caught on CI. |
|
Right, we don't need to golden check every playground - but it sounds like if we have validation enabled and this test wasn't failing when I landed my PR, this test must not be running? |
|
I think the test was running with validations without a single playground frame being renderered. |
|
Can we set that flag on CI? |
|
TBH, I thought we already were. Filed flutter/flutter#142995 to followup. |
Viewports, scissors, and stencil reference values are part of the dynamic state and must be initialized in the case where the caller doesn't set any value via the render pass. Fixes flutter/flutter#142943
chinmaygarde
force-pushed
the
stencil_reference
branch
from
a51b4a2 to
366f9ee
Compare
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50373, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50373, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chinmaygarde
added
the
autosubmit
…143112) flutter/engine@19ae46a...e4a5acc 2024-02-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision)" (flutter/engine#50450) 2024-02-07 [email protected] Roll Skia from a2fe78a31a14 to eacaa2d3600c (3 revisions) (flutter/engine#50445) 2024-02-07 [email protected] [Impeller] Initialize the stencil reference value. (flutter/engine#50373) 2024-02-07 [email protected] Roll Skia from 9b103a4148e2 to a2fe78a31a14 (2 revisions) (flutter/engine#50441) 2024-02-07 [email protected] Fixed CONTRIBUTING.md markdown lints (flutter/engine#50439) 2024-02-07 [email protected] Roll Skia from 7777976cd518 to 9b103a4148e2 (1 revision) (flutter/engine#50438) 2024-02-07 [email protected] Roll Dart SDK from 452dd17120b7 to 322c81160fa9 (1 revision) (flutter/engine#50437) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Viewports, scissors, and stencil reference values are part of the dynamic state and must be initialized in the case where the caller doesn't set any value via the render pass.
Fixes flutter/flutter#142943