Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Jan 31, 2024

This change enables tests requiring multiple packages in both debug and release builders; though the AOT test cannot be executed.
Also 4 out of 5 suites are excluded from release builder since some of the tests are failing; it's worth extra investigation.
MouseInputTest in theory is enabled, it indeed contains only disabled tests.

Bug: flutter/flutter#140179

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zijiehe-google-com zijiehe-google-com changed the title fuchsia tests [Fuchsia] Run tests with multiple packages Feb 1, 2024
@zijiehe-google-com zijiehe-google-com marked this pull request as ready for review February 1, 2024 04:14
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with changes)

@zijiehe-google-com
Copy link
Contributor Author

Thank you.

@zijiehe-google-com zijiehe-google-com merged commit a632531 into flutter:main Feb 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants