Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

Reland of #50028 , which was reverted because I missed the different API level requirement of getId. getID now returns an optional which is nullopt on API level < 31.

Fixes flutter/flutter#142365

@johnmccutchan johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit auto-submit bot merged commit f7cadda into flutter:main Jan 30, 2024
@jonahwilliams jonahwilliams deleted the reuse_vk_image branch January 30, 2024 17:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2024
…142548)

flutter/engine@0e4342c...cd12316

2024-01-30 [email protected] Roll Dart SDK from 10bbb376de7e to 734aae9604e8 (1 revision) (flutter/engine#50179)
2024-01-30 [email protected] [Impeller] added mipmaps to subpasses directly on a draw call (flutter/engine#50157)
2024-01-30 [email protected] Manual roll Dart SDK from d0b48a008559 to 10bbb376de7e (8 revisions) (flutter/engine#50172)
2024-01-30 [email protected] Roll Skia from 7df4d35e11cf to 739b66191c66 (1 revision) (flutter/engine#50175)
2024-01-30 [email protected] [Android] Reland: recycle hardware buffer textures. (flutter/engine#50122)
2024-01-30 [email protected] Roll buildroot to 52689fe8955a9a4916a38f0b8ae5ea3e217037f4 (flutter/engine#50160)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HardwareBuffer Id lookup failed on firebase test lab

2 participants