This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable header_guard_check (and --fix) in ci/format
#50102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Jan 26, 2024
| final StringSink _stdOut; | ||
|
|
||
| /// Stderr. | ||
| final StringSink _stdErr; |
Member
There was a problem hiding this comment.
pedantic nit: why not just _stdout, _stderr to match capitalisation elsewhere, and in the dart IO APIs?
Contributor
Author
There was a problem hiding this comment.
Because I hate myself I suppose.
cbracken
approved these changes
Jan 26, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
nice! Thanks for fixing up/enforcing this.
Contributor
Author
|
@gaaclarke I am going to land this to get enforcement in before header files are added/changed, but please still leave comments and I'll send a follow-up PR. Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2024
…142359) flutter/engine@45c06c2...2687ddb 2024-01-27 [email protected] Enable `header_guard_check` (and `--fix`) in `ci/format` (flutter/engine#50102) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#133415.
This includes a performance optimization for the runner itself, where
--include=...s are used as a base to check, versus checking every file and seeing if it exists in a list. This works better with what is expected inci/bin/format.dartwithout any contract change.Also added a few more functional tests of the system.