This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor the linux_android targets to make use of recent changes to android virtual device params #50099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
approved these changes
Jan 30, 2024
Contributor
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
LGTM with recipes supporting CL landing first.
ricardoamador
force-pushed
the
use_proto_name_andemulator
branch
from
6b10a52 to
f35a22b
Compare
ricardoamador
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
…anges to android virtual device params (flutter/engine#50099)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
…anges to android virtual device params (flutter/engine#50099)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
…anges to android virtual device params (flutter/engine#50099)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
…142783) flutter/engine@dd4c79a...b35153d 2024-02-02 [email protected] Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) (flutter/engine#50264) 2024-02-01 [email protected] Remove number of arguments from defining Dart FFI (flutter/engine#50153) 2024-02-01 [email protected] Refactor the linux_android targets to make use of recent changes to android virtual device params (flutter/engine#50099) 2024-02-01 [email protected] Re-add tests deleted on accident (flutter/engine#50223) 2024-02-01 [email protected] [Impeller] updated todos from opengles golden work (flutter/engine#50218) 2024-02-01 [email protected] Get bounds from RTree in DLBuilder::Build() (flutter/engine#50253) 2024-02-01 [email protected] [Impeller] Remove unused define. (flutter/engine#50250) 2024-02-01 [email protected] Add the focus state related methods to the platform dispatcher (flutter/engine#49841) 2024-02-01 [email protected] Fix the output paths of the Web esbuild GN template (flutter/engine#50188) 2024-02-01 [email protected] [Impeller] Delete unnecessary special casing for Vulkan in framebuffer fetch. (flutter/engine#50251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to use the proto.textpb config file as the version of the emulator device and show the cipd dependency version in the dependencies so devs know it can be updated.
This will not pass until recipe changes have landed.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#142261
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.