Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reverts "Optimizations for TLHC frame rate and jank" #50062

Merged
auto-submit merged 1 commit into from
Jan 25, 2024
Merged

Reverts "Optimizations for TLHC frame rate and jank" #50062

auto-submit merged 1 commit into from
Jan 25, 2024

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 25, 2024

Reverts #50033
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

  • ImageReaderSurfaceProducer no longer drops frames when the producer and the consumers are up to two frames out of sync.
  • Have the native C++ side of the Android external textures check if a new frame has been pushed and that the texture needs to be updated. This avoids having to schedule a task on the raster thread for each updated texture.
  • Notify the engine earlier that a frame is needed when updating a TLHC texture.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 25, 2024
@auto-submit auto-submit bot merged commit 9142fc4 into main Jan 25, 2024
@auto-submit auto-submit bot deleted the revert_57099ca78d876c4483b4024b139978bc1ab1bda5 branch January 25, 2024 23:31
@zanderso
Copy link
Member

zanderso commented Jan 25, 2024

Consistent failure on framework CI like https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_view_scroll_perf__timeline_summary/13249/overview

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Jan 25, 2024

got it, thanks!

@zanderso
Copy link
Member

zanderso commented Jan 25, 2024 

[2024-01-25 15:11:53.271443] [STDOUT] stdout: [  +81 ms] F/flutter (25701): [FATAL:flutter/shell/platform/android/surface_texture_external_texture.cc(54)] Check failed: state_ == AttachmentState::kAttached. 
[2024-01-25 15:11:53.273177] [STDOUT] stdout: [   +1 ms] F/libc    (25701): Fatal signal 6 (SIGABRT), code -6 in tid 25719 (1.raster)
[2024-01-25 15:11:53.309456] [STDOUT] stdout: [  +36 ms] 00:00 �[32m+0�[0m: scrolling performance test platform_views_scroll_perf_hybrid_composition�[0m
[2024-01-25 15:11:53.348888] [STDOUT] stdout: [  +39 ms] *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
[2024-01-25 15:11:53.349259] [STDOUT] stdout: [        ] Build fingerprint: 'motorola/athene/athene:7.0/NPJS25.93-14-18/3:user/release-keys'
[2024-01-25 15:11:53.349323] [STDOUT] stdout: [        ] Revision: 'p2a0'
[2024-01-25 15:11:53.349392] [STDOUT] stdout: [        ] ABI: 'arm'
[2024-01-25 15:11:53.349423] [STDOUT] stdout: [        ] pid: 25701, tid: 25719, name: 1.raster  >>> dev.benchmarks.platform_views_layout_hybrid_composition <<<
[2024-01-25 15:11:53.349492] [STDOUT] stdout: [        ] signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
[2024-01-25 15:11:53.349719] [STDOUT] stdout: [        ] Abort message: '[FATAL:flutter/shell/platform/android/surface_texture_external_texture.cc(54)] Check failed: state_ == AttachmentState::kAttached. 
[2024-01-25 15:11:53.349771] [STDOUT] stdout: [        ] '
[2024-01-25 15:11:53.349821] [STDOUT] stdout: [        ]     r0 00000000  r1 00006477  r2 00000006  r3 00000008
[2024-01-25 15:11:53.349841] [STDOUT] stdout: [        ]     r4 94905978  r5 00000006  r6 94905920  r7 0000010c
[2024-01-25 15:11:53.349987] [STDOUT] stdout: [        ]     r8 a8246994  r9 00000004  sl 00000000  fp 94904df8
[2024-01-25 15:11:53.350054] [STDOUT] stdout: [        ]     ip 00000000  sp 949049f8  lr b12373e7  pc b1239c44  cpsr 20000010
[2024-01-25 15:11:53.356953] [STDOUT] stdout: [   +6 ms] backtrace:
[2024-01-25 15:11:53.357374] [STDOUT] stdout: [        ]     #00 pc 00049c44  /system/lib/libc.so (tgkill+12)
[2024-01-25 15:11:53.358003] [STDOUT] stdout: [        ]     #01 pc 000473e3  /system/lib/libc.so (pthread_kill+34)
[2024-01-25 15:11:53.358337] [STDOUT] stdout: [        ]     #02 pc 0001d535  /system/lib/libc.so (raise+10)
[2024-01-25 15:11:53.358359] [STDOUT] stdout: [        ]     #03 pc 00019081  /system/lib/libc.so (__libc_android_abort+34)
[2024-01-25 15:11:53.358391] [STDOUT] stdout: [        ]     #04 pc 000170e4  /system/lib/libc.so (abort+4)
[2024-01-25 15:11:53.358417] [STDOUT] stdout: [        ]     #05 pc 00010b0b  /data/app/dev.benchmarks.platform_views_layout_hybrid_composition-1/lib/arm/libflutter.so (offset 0x635000)

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 26, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 26, 2024
@engine-flutter-autoroll
9142fc4f1 Reverts "Optimizations for TLHC frame rate and jank" (flutt…
227fa73 
…er/engine#50062)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 26, 2024
@engine-flutter-autoroll
Manual roll Flutter Engine from 4b145d041560 to 9142fc4f16a5 (12 revi…
2b2b37e 
…sions) (#142278)

Manual roll requested by [email protected]

flutter/engine@4b145d0...9142fc4

2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Optimizations for TLHC frame rate and jank" (flutter/engine#50062)
2024-01-25 [email protected] [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035)
2024-01-25 [email protected] Fix android new engine in group (flutter/engine#49659)
2024-01-25 [email protected] Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013)
2024-01-25 [email protected] Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054)
2024-01-25 [email protected] Fix a typo in ChannelBuffers documentation (flutter/engine#49928)
2024-01-25 [email protected] Add include suggested by clang-tidy (flutter/engine#49898)
2024-01-25 [email protected] Refactor macOS trackpad gesture tracking (flutter/engine#49424)
2024-01-25 [email protected] winding order from tesellator.h to formats.h (flutter/engine#49865)
2024-01-25 [email protected] Roll webp to 1.3.2 (flutter/engine#49883)
2024-01-25 [email protected] Optimizations for TLHC frame rate and jank (flutter/engine#50033)
2024-01-25 [email protected] Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

1 more reviewer

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zanderso zanderso

Labels

platform-android revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @johnmccutchan @fluttergithubbot