This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix advanced blend alpha issue, improve blend goldens. #50035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Still working out the premul issue and will probably append it to this patch... just pushing now to verify the blend golden changes look reasonable on CI. |
bdero
force-pushed
the
bdero/blend-alpha-fix
branch
from
c2fa182 to
db8a152
Compare
Member
Author
|
actually I'm gonna land this tiny fix first with the improved goldens. I still need to figure out how to repro the specific premul issue in a golden. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
force-pushed
the
bdero/blend-alpha-fix
branch
from
db8a152 to
7658d7c
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2024
…sions) (#142278) Manual roll requested by [email protected] flutter/engine@4b145d0...9142fc4 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Optimizations for TLHC frame rate and jank" (flutter/engine#50062) 2024-01-25 [email protected] [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035) 2024-01-25 [email protected] Fix android new engine in group (flutter/engine#49659) 2024-01-25 [email protected] Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013) 2024-01-25 [email protected] Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054) 2024-01-25 [email protected] Fix a typo in ChannelBuffers documentation (flutter/engine#49928) 2024-01-25 [email protected] Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 [email protected] Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 [email protected] winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 [email protected] Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 [email protected] Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 [email protected] Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out one of the problems...
Multiply before (notice weird alpha behavior on the bird):
Multiply after:
