This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not double-increment nextId when using createSurfaceProducer with SurfaceTextures
#50011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
…roducer` with `SurfaceTexture`s (flutter/engine#50011)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2024
…142176) flutter/engine@ed498f1...6a7f963 2024-01-24 [email protected] Roll Fuchsia Linux SDK from kYC2-fFgjbb36mukB... to Igt2rE-R6rgfmTRaF... (flutter/engine#50015) 2024-01-24 [email protected] Roll Skia from 9ea7cb490804 to 643160445720 (6 revisions) (flutter/engine#50014) 2024-01-24 [email protected] Add custom FlValue types and support their en/decoding via FlStandardMessageCodec (flutter/engine#49162) 2024-01-24 [email protected] Do not double-increment `nextId` when using `createSurfaceProducer` with `SurfaceTexture`s (flutter/engine#50011) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kYC2-fFgjbb3 to Igt2rE-R6rgf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is very tiny, but I added some documentation as well.
After this PR, it appears we're "ready" to start using this API once it lands in stable. Hoorah!
Here are local tests using
video_player_android/example:Skia
Impeller