Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@sealesj
Copy link
Contributor

@sealesj sealesj commented Jan 24, 2024

Final migration away from github + fuchsia, cleanup references.

New mirrors stood up at https://flutter.googlesource.com/third_party/ocmock/, https://flutter.googlesource.com/third_party/protobuf/,
https://flutter.googlesource.com/third_party/protobuf-gn/ and all three are verified to be publically readable.

Addresses b/316411022

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj marked this pull request as ready for review January 24, 2024 19:26
@sealesj sealesj requested a review from zanderso January 24, 2024 19:26
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024
@auto-submit auto-submit bot merged commit 15cbd42 into flutter:main Jan 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 24, 2024
…142167)

flutter/engine@4bc368e...ed498f1

2024-01-24 [email protected] [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994)
2024-01-24 [email protected] Fuchsia + ocmock mirror migration (flutter/engine#50003)
2024-01-24 [email protected] Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009)
2024-01-24 [email protected] [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995)
2024-01-24 [email protected] [Impeller] Share vulkan playground across goldens (flutter/engine#49981)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants