This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Fix: Memory sanitizer violated when encoding indirect strings #49995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
Jan 24, 2024
cbracken
reviewed
Jan 24, 2024
| CFIndex buffer_length = length * 3; | ||
| std::vector<UInt8> buffer; | ||
| buffer.reserve(buffer_length); | ||
| buffer.resize(buffer_length); |
Member
There was a problem hiding this comment.
Oh wow; nice catch. I'm somewhat surprised this hasn't caused issues other than tipping off ASAN!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2024
…142167) flutter/engine@4bc368e...ed498f1 2024-01-24 [email protected] [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994) 2024-01-24 [email protected] Fuchsia + ocmock mirror migration (flutter/engine#50003) 2024-01-24 [email protected] Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009) 2024-01-24 [email protected] [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995) 2024-01-24 [email protected] [Impeller] Share vulkan playground across goldens (flutter/engine#49981) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#142101
@cbracken However, this unit test requires the unit tests to be compiled with
--asanto work. Can we add this flag to CI?Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.