This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] allow non-square corner radii for fast blurs #49994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Contributor
Author
|
Should I also make the adjustments to the test that were included in #49989? |
Member
|
I think it's fine to leave it as-is. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2024
…142167) flutter/engine@4bc368e...ed498f1 2024-01-24 [email protected] [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994) 2024-01-24 [email protected] Fuchsia + ocmock mirror migration (flutter/engine#50003) 2024-01-24 [email protected] Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009) 2024-01-24 [email protected] [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995) 2024-01-24 [email protected] [Impeller] Share vulkan playground across goldens (flutter/engine#49981) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flar
added a commit
to flar/engine
that referenced
this pull request
Jan 24, 2024
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y. Fixes flutter/flutter#141850 Obsoletes flutter#49989
zanderso
pushed a commit
to flar/engine
that referenced
this pull request
Jan 24, 2024
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y. Fixes flutter/flutter#141850 Obsoletes flutter#49989
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Cherry-picks #49994 into release candidate 3.19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y.
Fixes flutter/flutter#141850
Obsoletes #49989