[Impeller] Remove RRect blur zero sigma branch. #49989
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
isn't this for negative blur values?
bdero
force-pushed
the
bdero/rrectblur-zero-sigma
branch
from
627a151 to
f212882
Compare
|
Yeah we should just not blur in that case since this path will cause it to render with aliased edges. Updated the patch. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
I'm rewriting all of this code in an as-yet unsubmitted PR. This PR should be obsolete at that point.
|
See #49994 |
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y. Fixes flutter/flutter#141850 Obsoletes #49989
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y. Fixes flutter/flutter#141850 Obsoletes flutter#49989
Upgrades the fast blur shader to work with round rects and ovals that have different radii in X and Y. Fixes flutter/flutter#141850 Obsoletes flutter#49989
3 participants
Pointed out by @flar during a conversation. We don't need to handle this case because we already early return in the Contents when we're close to zero.