This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Introduce egl::Context #49954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
force-pushed
the
windows_egl_context
branch
3 times, most recently
from
48b1b8f to
4c26abf
Compare
cbracken
reviewed
Jan 23, 2024
cbracken
reviewed
Jan 23, 2024
cbracken
reviewed
Jan 23, 2024
cbracken
reviewed
Jan 23, 2024
cbracken
reviewed
Jan 23, 2024
cbracken
approved these changes
Jan 23, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm modulo a couple nits! Nice refactor.
loic-sharma
force-pushed
the
windows_egl_context
branch
from
3b42be0 to
862a3db
Compare
yaakovschectman
approved these changes
Jan 23, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
…142071) flutter/engine@57d6b51...11a16d8 2024-01-23 [email protected] [Web] Fix an assertion error due to synthesized keyboard events (flutter/engine#49087) 2024-01-23 [email protected] [Windows] Introduce egl::Context (flutter/engine#49954) 2024-01-23 [email protected] Roll Fuchsia Linux SDK from uQK4l0QeH_PlZO6cF... to kYC2-fFgjbb36mukB... (flutter/engine#49976) 2024-01-23 [email protected] Roll Skia from 58973cca0edd to 59a70a1efc39 (17 revisions) (flutter/engine#49975) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uQK4l0QeH_Pl to kYC2-fFgjbb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
egl::Contexttype that abstracts a rawEGLContext. This also removes the EGL context logic out fromEGLManager.Part of flutter/flutter#141996
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.