This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Fix runtime effect pipeline depth/stencil. #49953
Merged
bdero
merged 7 commits into
flutter:main
from
bdero:bdero/fix-runtimeeffect-depthstencil-ops
Jan 23, 2024
Merged
[Impeller] Fix runtime effect pipeline depth/stencil. #49953
bdero
merged 7 commits into
flutter:main
from
bdero:bdero/fix-runtimeeffect-depthstencil-ops
Jan 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a820e9 to
223e987
Compare
dnfield
reviewed
Jan 23, 2024
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test?
Member
Author
|
Yeah that's what I'm working on. Need to repro the validation error somehow to come up with a test case. |
Contributor
|
I'm not sure if its related, but I'm also getting a Vulkan validation error with runtime effect now |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Yup that's for sure the same problem. |
ad0fa3f to
8e55615
Compare
Member
Author
|
I added a test to verify the attachments end up being correct. |
da22378 to
847c29a
Compare
dnfield
approved these changes
Jan 23, 2024
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
Haven't verified this locally yet but seems good. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
…142067) flutter/engine@9940541...57d6b51 2024-01-23 [email protected] [Impeller] fix validation error for playground texture upload. (flutter/engine#49957) 2024-01-23 [email protected] [Impeller] Fix runtime effect pipeline depth/stencil. (flutter/engine#49953) 2024-01-23 [email protected] Exclude prebuilts/Library from Mac builder_cache (flutter/engine#49971) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityPassto force backends to set things up the root pass correctly.ContentContextOptions::ApplyToPipelineDescriptorto validate that callers are holding it right.