-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Enable playgrounds on host platforms that support Vulkan. #49949
Conversation
gaaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. The test failures seem apropos though, it's kind of surprising this change has any effect on them.
|
"Attempted to initialize a Vulkan playground on macOS where Vulkan cannot be found. It can be installed via MoltenVK and make sure to install it globally so dlopen can find it.". This is on Linux. Something is deeply confused. |
|
Wait, what is |
I suspect that this is just a failure to load vulkan and the error message is macos centric. Is |
|
This isn't linux. I filed flutter/flutter#142010 to fix the confusingly named bot. I don't think this bot has Molten and the playgrounds aren't configured for SwiftShader. I'll just skip the tests in this configuration. |
Oh that's mac, if you click into the results like https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/648482/overview you can see it. I don't know the right nomenclature but that is a linux bot dishing out tasks to mac bots. |
|
Ok, attempting to run a playground on a host that doesn't support Vulkan even via Molten shouldn't be an error anymore. We can patch it later to work with SwiftShader but that is a heavier lift. I'll investigate the other validation error. |
Running with swiftshader should be an easy change. We are already doing it for the |
|
Wilco on investigating running it with SwiftShader. The current validation error is pasted below. I think this one is real. Investigating a fix. |
|
Oof. Thats just a single validation error. Theres loads more when I make the harness not tear down on validation error. https://gist.github.com/chinmaygarde/c2c4025fcf452a9ef67618c740b71425 |
|
I think @gaaclarke and I have fixed most of these validation errors. What are the remaining blockers? |
|
Good to know. I'll rebase and check again to see if I get a clean run. |
2ad8d50 to
ed6d6ab
Compare
…to enabling that backend. Now, you get playgrounds no all backends if you enable that backend. Second attempt at flutter#49949
Fixes flutter/flutter#142003