Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Jan 22, 2024

This change is a redo of #49847.

https://github.com/zijiehe-google-com/engine/compare/4530942..main should show the diff between this and the original change; mainly fixes the flutter/flutter#141907.

Following paragraph is copied from the original change.

This change can be executed from buildroot by

python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py

Bug: flutter/flutter#140179

  • [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [V] I listed at least one issue that this PR fixes in the description above.
  • [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • [V] I updated/added relevant documentation (doc comments with ///).
  • [V] I signed the [CLA].
  • [V] All existing and new tests are passing.

@zijiehe-google-com zijiehe-google-com marked this pull request as draft January 22, 2024 19:00
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@jrwang jrwang merged commit 7c4ed15 into flutter:main Jan 25, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants