This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] dont emulate command buffers for compute on Metal/Vulkan. #49922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 22, 2024
| /// There should be no change to rendering if this caching was | ||
| /// absent. | ||
| /// | ||
| struct ComputePassBindingsCache { |
Member
There was a problem hiding this comment.
ComputePassBindingsCacheMTL. The MTL suffix for non-backend-agnostic classes.
| using TextureMap = std::map<uint64_t, id<MTLTexture>>; | ||
| using SamplerMap = std::map<uint64_t, id<MTLSamplerState>>; | ||
|
|
||
| id<MTLComputeCommandEncoder> encoder_; |
Member
There was a problem hiding this comment.
= nil (or nullptr like the rest) this out. IIRC, ObjC ivars aren't zero initialized in C++.
| auto width = grid_size.width; | ||
| auto height = grid_size.height; | ||
|
|
||
| auto maxTotalThreadsPerThreadgroup = static_cast<int64_t>( |
Member
There was a problem hiding this comment.
Here and elsewhere, the use underscore_case for vars instead of camelCase.
Member
There was a problem hiding this comment.
Oh, I see this was just code that was moved. Just the same, a drive-by change to make this conform the style would be good.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
…142023) flutter/engine@d3dbd42...df6b15d 2024-01-22 [email protected] [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922) 2024-01-22 [email protected] [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941) 2024-01-22 [email protected] [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913) 2024-01-22 [email protected] [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948) 2024-01-22 [email protected] [Windows] Rename and move EGL types (flutter/engine#49900) 2024-01-22 [email protected] Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for: flutter/flutter#140804
Removes ComputeCommand and has both ComputePassMTL and ComputePassVK immediately record to their respective comand buffers. This combines the commits for Metal/Vulkan as they are both fairly small. After this, I can add barriers to fix compute for Vulkan.