This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" #49908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jan 19, 2024
auto-submit
bot
deleted the
revert_ebee709bc5497b1b9a3813afc2192ef0bbb2f6fc
branch
Member
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2024
…load images and execute tests" (flutter/engine#49908)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2024
…141914) flutter/engine@d00e55f...a9b87c6 2024-01-20 [email protected] [Impeller] null check vertex buffer. (flutter/engine#49915) 2024-01-19 [email protected] [Impeller] adds vulkan golden images (flutter/engine#49849) 2024-01-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests" (flutter/engine#49908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zijiehe-google-com
added a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 22, 2024
…ad images and execute tests" (flutter#49908)" This reverts commit d3ba13d.
zijiehe-google-com
added a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 22, 2024
…ad images and execute tests" (flutter#49908)" This reverts commit d3ba13d.
zijiehe-google-com
added a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 23, 2024
…ad images and execute tests" (flutter#49908)" This reverts commit d3ba13d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49847
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This change is a redo of #49650.
https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change.
Following paragraph is copied from the original change.
This change requires flutter/buildroot#811, and can be executed from buildroot by
Bug: flutter/flutter#140179
Pre-launch Checklist
///).