This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Rename and move EGL types #49900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
loic-sharma
force-pushed
the
windows_split_egl
branch
2 times, most recently
from
445666e to
f6a7c49
Compare
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
This is a refactoring with no semantic changes: 1. Fixes incorrect style in `AngleSurfaceManager` 2. Cleans `AngleSurfaceManager`'s initialization logic Next pull request: #49900 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
loic-sharma
force-pushed
the
windows_split_egl
branch
from
f6a7c49 to
a90722e
Compare
loic-sharma
force-pushed
the
windows_split_egl
branch
from
4cf715a to
72265cb
Compare
yaakovschectman
approved these changes
Jan 22, 2024
Contributor
yaakovschectman
left a comment
yaakovschectman
left a comment
There was a problem hiding this comment.
Looks good. Should we open/link to an issue for this?
Member
Author
|
@yaakovschectman Good idea, opened: flutter/flutter#141996 |
loic-sharma
force-pushed
the
windows_split_egl
branch
from
72265cb to
d8f7a80
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
…142023) flutter/engine@d3dbd42...df6b15d 2024-01-22 [email protected] [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922) 2024-01-22 [email protected] [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941) 2024-01-22 [email protected] [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913) 2024-01-22 [email protected] [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948) 2024-01-22 [email protected] [Windows] Rename and move EGL types (flutter/engine#49900) 2024-01-22 [email protected] Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring with no semantic changes. The following types were renamed:
flutter::AngleSurfaceManagertoflutter::egl::Manager. In subsequent pull requests, this type will create but not own surfaces. Furthermore, this type will be split up to introduceflutter::egl::Surfaceandflutter::egl::Context. The manager will own the contexts and each surface will be owned by its view.flutter::GlProcTabletoflutter::egl::ProcTableThis also introduces an
egldirectory to the Windows embedder.Previous pull request: #49895
Part of flutter/flutter#141996
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.