Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Jan 17, 2024

This change is a redo of #49650.

https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change.

Following paragraph is copied from the original change.

This change requires flutter/buildroot#811, and can be executed from buildroot by

python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py

Bug: flutter/flutter#140179

Pre-launch Checklist

  • [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [V] I listed at least one issue that this PR fixes in the description above.
  • [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • [V] I updated/added relevant documentation (doc comments with ///).
  • [V] I signed the [CLA].
  • [V] All existing and new tests are passing.

@zijiehe-google-com zijiehe-google-com changed the title [Fuchsia - redo] Use chromium test-scripts to download images and execute tests [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests Jan 18, 2024
@zanderso zanderso merged commit ebee709 into flutter:main Jan 19, 2024
@zijiehe-google-com
Copy link
Contributor Author

Thank you.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2024
…141886)

flutter/engine@538975f...c953c83

2024-01-19 [email protected] [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816)
2024-01-19 6844906[email protected] [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847)
2024-01-19 [email protected] Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Jan 19, 2024
auto-submit bot pushed a commit that referenced this pull request Jan 19, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jan 19, 2024
auto-submit bot added a commit that referenced this pull request Jan 19, 2024
…s and execute tests" (#49908)

Reverts #49847
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This change is a redo of #49650.

https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change.

Following paragraph is copied from the original change.

This change requires flutter/buildroot#811, and can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: flutter/flutter#140179

- [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description above.
- [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
jrwang pushed a commit that referenced this pull request Jan 25, 2024
…cute tests (#49940)

This change is a redo of #49847.

https://github.com/zijiehe-google-com/engine/compare/4530942..main
should show the diff between this and the original change; mainly fixes
the flutter/flutter#141907.

Following paragraph is copied from the original change.

This change can be executed from buildroot by

```
python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py
```

Bug: flutter/flutter#140179

- [V] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [V] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [V] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [V] I listed at least one issue that this PR fixes in the description
above.
- [V] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [V] I updated/added relevant documentation (doc comments with `///`).
- [V] I signed the [CLA].
- [V] All existing and new tests are passing.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants