[Impeller] remove shared_ptr copies during text contents rendering. #49837
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I actually did have to update a test :) |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM, this is only worthwhile if the callers aren't copying it too so make sure you review those. This is definitely an improvement. I would like us to return errors at some point instead of returning null, but that's a change for another day.
jonahwilliams
added
the
autosubmit
…141751) flutter/engine@924c172...48f89ac 2024-01-18 [email protected] Delete trace event from DeviceBufferVK (flutter/engine#49854) 2024-01-18 [email protected] [Impeller] remove shared_ptr copies during text contents rendering. (flutter/engine#49837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
We copied the shared ptr to make it easy to return nullptr, but instead we could use a static const assigned to nullptr