This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Properly size struct emplacements for Vulkan Runtime Effects #49768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/49768, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
approved these changes
Jan 12, 2024
dnfield
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/49768, due to Pull request flutter/engine/49768 is not in a mergeable state. |
auto-submit
bot
removed
the
autosubmit
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 13, 2024
…141496) flutter/engine@205ed68...b06478b 2024-01-12 [email protected] [Impeller] Properly size struct emplacements for Vulkan Runtime Effects (flutter/engine#49768) 2024-01-12 [email protected] Fix linux_android_emulator_api_33 build config for rbe (flutter/engine#49776) 2024-01-12 [email protected] [Linux] Remove the usage of std::function in FlKeyEmbedderResponder (flutter/engine#49293) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in the runtime effects PR.
This bug sometimes causes a segfault when we go to
memmovelatter with an incorrect length/size/num parameter.