This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-enable osv-scanner on pushes to main #49729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Jan 12, 2024
| # Only the default branch is supported. | ||
| branch_protection_rule: | ||
| push: | ||
| branches: [ main ] |
Contributor
There was a problem hiding this comment.
Would this be non-blocker?
Contributor
Author
There was a problem hiding this comment.
Yes this is non blocking because of fail-on-vuln: false
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
@godofredoc Does this look good to you? |
zanderso
approved these changes
Jan 18, 2024
godofredoc
approved these changes
Jan 18, 2024
sealesj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2024
…141881) flutter/engine@9a6c64d...538975f 2024-01-19 [email protected] Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891) 2024-01-19 [email protected] Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890) 2024-01-19 [email protected] Re-enable osv-scanner on pushes to main (flutter/engine#49729) 2024-01-19 [email protected] Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889) 2024-01-19 [email protected] Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888) 2024-01-19 [email protected] Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887) 2024-01-19 [email protected] Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886) 2024-01-19 [email protected] [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dTy8CK4YxnUs to geXIwPzzJiSX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osv-scanner workflow was disabled on pushes to main while testing the PR patching workflow. This change re-enables the scanner to run on pushes to main (excluding forks).
Successful run of the current vulnerability workflow here: https://github.com/flutter/engine/actions/runs/7561640856/job/20590736333
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.