This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" #49671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jan 10, 2024
auto-submit
bot
deleted the
revert_f989a5529ab6b8d52d0e972d4d53d212514c9a91
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 10, 2024
…141271) flutter/engine@3269fd8...b361a60 2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49203
Initiated by: whesse
This change reverts the following previous change:
Original Description:
Flutter dependencies coming from Github origins need to be mirrored so that they are not taken directly from github. This is part of an effort to standardize the dependency sources from third party dependencies.
Google is creating internal mirrors for these public repos, but we would be limited by the relatively strict access placed on those new repos, requiring this solution of Flutter GoB mirrors (as has already been done with non-Google Github repos and also Fuchsia-owned mirrors)
List which issues are fixed by this PR. You must list at least one issue.
Addresses b/316597637
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.