This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Track HostBuffer emplacements by offset. #49618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2024
…141209) flutter/engine@a35e3b0...693af0c 2024-01-09 [email protected] Roll Dart SDK from 721fccffc708 to 727ea68c62d8 (1 revision) (flutter/engine#49647) 2024-01-09 [email protected] Roll Skia from 77534b672363 to 4ef1837c2958 (1 revision) (flutter/engine#49643) 2024-01-09 [email protected] Roll Skia from 8c8be76a62c0 to 77534b672363 (1 revision) (flutter/engine#49641) 2024-01-09 [email protected] Roll Fuchsia Linux SDK from 6z4cZ6HUidtgmhvdk... to pUQrgMfXgU8RmLuL4... (flutter/engine#49640) 2024-01-09 [email protected] [Flutter GPU] Track HostBuffer emplacements by offset. (flutter/engine#49618) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 6z4cZ6HUidtg to pUQrgMfXgU8R If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zijiehe-google-com
pushed a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 9, 2024
Make the wrapped HostBuffer wrapper track/look up emplacements using a fake byte offset. This is a trick to keep Flutter GPU working after flutter#49505 lands. I'll likely swing around and change how `BufferView` works later on. We can simplify a lot by making Flutter GPU `BufferView`s just take `DeviceBuffer` handles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the wrapped HostBuffer wrapper track/look up emplacements using a fake byte offset.
This is a trick to keep Flutter GPU working after #49505 lands. I'll likely swing around and change how
BufferViewworks later on. We can simplify a lot by making Flutter GPUBufferViews just takeDeviceBufferhandles.