[Impeller] Document mip bias. #49602
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is following up on a conversation in the impeller room: https://discord.com/channels/608014603317936148/1173336353187041380/1193987717122494614 |
|
test-exempt: comment-only change |
|
(It looks like this file type should probably be added here?) |
…141147) flutter/engine@3f0f891...d134799 2024-01-09 [email protected] Roll Skia from cb8e8fa79132 to f4626a2e3293 (3 revisions) (flutter/engine#49610) 2024-01-09 [email protected] [Impeller] Document mip bias. (flutter/engine#49602) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Add doc strings explaining what the mip bias does and where it came from.