This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag #49563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
Update SaveLayerConsolidation unit tests to allow 1px differences due to rounding differences when Skia elides image filter passes and can calculate the CF and opacity in full float without an intermediate conversion to 8-bit color.
lhkbob
force-pushed
the
resolve-filters-before-restore-remove
branch
from
86acffa to
7b08d19
Compare
Member
|
(triage) I spoke to @lhkbob last week and they said they plan to come back to this PR soon. |
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/49563, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
…b.com/lhkbob/engine into resolve-filters-before-restore-remove
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/49563, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2024
…149447) flutter/engine@fa30658...1814031 2024-05-31 [email protected] Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag (flutter/engine#49563) 2024-05-31 [email protected] Remove complexity calculator with Slimpeller (flutter/engine#53140) 2024-05-31 [email protected] Roll Skia from 208469d270b7 to f1f13534b0c2 (1 revision) (flutter/engine#53152) 2024-05-31 [email protected] Roll Skia from ce975ddfd9fb to 208469d270b7 (1 revision) (flutter/engine#53150) 2024-05-31 [email protected] Google java format relocation and formatting update (flutter/engine#53118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jun 3, 2024
flutter/engine#49563 removed the last reliance on the old behavior. Bug: b/40042615 Change-Id: I2b16189e30ff763896fb463f80e803e8608f2de3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859127 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Michael Ludwig <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SaveLayerConsolidation unit tests to allow 1px differences due to rounding differences when Skia elides image filter passes and can calculate the CF and opacity in full float without an intermediate conversion to 8-bit color.
This is the last remaining use of the staging that will allow closing https://g-issues.skia.org/issues/40042615.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.