Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Use Mac M1s or x86 wherever possible. (#49540) #49545

Merged
godofredoc merged 1 commit into from
Jan 5, 2024
Merged

CP: Use Mac M1s or x86 wherever possible. (#49540) #49545

godofredoc merged 1 commit into from
Jan 5, 2024

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jan 4, 2024

Arch type was fixed to x86 because release candidate branches didn't have rosetta installed. Rosetta was enabled on December unblocking the use of M1 machines in most of mac ios sub-builds.

Bug: flutter/flutter#133207

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use Mac M1s or x86 wherever possible. (#49540)
d5ba7db 
Arch type was fixed to x86 because release candidate branches didn't have rosetta installed. Rosetta was enabled on December unblocking the use of M1 machines in most of mac ios sub-builds.

Bug: flutter/flutter#133207

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 4, 2024

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc godofredoc mentioned this pull request Jan 4, 2024
Closed
@godofredoc godofredoc changed the title Use Mac M1s or x86 wherever possible. (#49540) CP: Use Mac M1s or x86 wherever possible. (#49540) Jan 4, 2024
@godofredoc godofredoc requested a review from vashworth January 4, 2024 23:05
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Jan 4, 2024

You're welcome to submit this, but we're shipping a new beta next week :-)

@godofredoc
Copy link
Contributor Author

godofredoc commented Jan 4, 2024

You're welcome to submit this, but we're shipping a new beta next week :-)
Sounds good, this will allow us to validate the changes in dart internal and identify any other changes that may be required to unblock the mac 13 migration.

@godofredoc godofredoc merged commit 062be63 into flutter:flutter-3.18-candidate.0 Jan 5, 2024
@godofredoc godofredoc deleted the flutter-3.18-candidate.0 branch January 5, 2024 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@vashworth vashworth vashworth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @CaseyHillers @vashworth