This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove LoggingSocketTest.UseSyslogOnFuchsia test #49524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test reads back logged messages on Fuchsia to verify that FML logging has the log sink setup correctly. However, it relies on internal implementation details of the Fuchsia log packet format, which recently changed (to support structured logging) and it broke this test. Since there isn't a supported way to parse structured log packets outside of the Fuchsia repository, I'm removing this test to unblock the SDK roll. flutter/flutter#140950 b/315973146
tarobins
approved these changes
Jan 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 4, 2024
…140959) flutter/engine@7d5a120...f539acf 2024-01-04 [email protected] Roll Fuchsia Linux SDK from Wgogr8K1YZdo7yOnn... to 0Q4I0x-Kt7T6DOE1b... (flutter/engine#49529) 2024-01-04 [email protected] [fuchsia] Remove LoggingSocketTest.UseSyslogOnFuchsia test (flutter/engine#49524) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Wgogr8K1YZdo to 0Q4I0x-Kt7T6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test reads back logged messages on Fuchsia to verify that FML logging has the log sink setup correctly. However, it relies on internal implementation details of the Fuchsia log packet format, which recently changed (to support structured logging) and it broke this test. Since there isn't a supported way to parse structured log packets outside of the Fuchsia repository, I'm removing this test to unblock the SDK roll.
flutter/flutter#140950
b/315973146
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.