This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Add libbackend_fuchsia_globals.so to common_libs #49484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrase
force-pushed
the
backend_fuchsia_globals
branch
from
d187e83 to
d742b97
Compare
Contributor
|
I created a flutter issue at flutter/flutter#140891 |
mbrase
force-pushed
the
backend_fuchsia_globals
branch
from
860e5d0 to
eec970a
Compare
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The libbackend_fuchsia_globals.so is now required by libsyslog.so, so include it in the list of Fuchsia common_libs.
mbrase
force-pushed
the
backend_fuchsia_globals
branch
from
eec970a to
243fd8f
Compare
Contributor
|
This is ready for merging. I am rolling the 16.20231205.1.1 SDK along with my fix due to a hard transition. I ran into another breakage when I attempted to roll a more recent SDK, so I'll fix that in a followup PR. |
mbrase
force-pushed
the
backend_fuchsia_globals
branch
3 times, most recently
from
efcdd1f to
243fd8f
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 4, 2024
…140936) flutter/engine@ab4098c...28ae9e3 2024-01-04 [email protected] [fuchsia] Add libbackend_fuchsia_globals.so to common_libs (flutter/engine#49484) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from CGyrUgA1M1yF to Wgogr8K1YZdo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libbackend_fuchsia_globals.so is now required by libsyslog.so, so include it in the list of Fuchsia common_libs.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
b/315973146
Pre-launch Checklist
///).